Kelly Tran: Hungry Cook What?#92
Open
KellyPT wants to merge 23 commits intoAda-C6:b/kelly_tran/masterfrom
Open
Kelly Tran: Hungry Cook What?#92KellyPT wants to merge 23 commits intoAda-C6:b/kelly_tran/masterfrom
KellyPT wants to merge 23 commits intoAda-C6:b/kelly_tran/masterfrom
Conversation
KellyPT
commented
Nov 8, 2016
KellyPT
commented
- I've completed all baseline requirements.
- I used Kaminari gem to handle pagination (documentation: https://github.com/amatsuda/kaminari). Prior to this decision, I explored will_paginate/api-pagination/api-pager gems but they all didn't work. Lesson learned: go FIRST with a gem that has detailed documentation because it will help me debug more easily.
- I think up to this project, I've become more comfortable with Foundation CSS.
- My test coverage is 100%. I think Dan's TDD lecture on Nov 7 really helped me with this test exercise.
- I spent a lot of time playing around with memoization. My method worked but were considered "illegitimate" by Dan. I did research on sessions/cookies and tried various ways for 7 hours. Realizing that this was too much time investment, I abandoned memoization altogether. Sorry Edamam! :-|
- It was a tough week as I was down with stomach flu.
…ised library. Added gem 'pry'
…ing method in api wrapper. Added 2 reset functions to handle cookies.
…ded comments for my own memorization.
…ather than calling API from APIwrapper, remove :recipe from class << self method and reset_one method
…to gitignore. Added API ID and key to API wrapper.
…other methods in recipe.rb model and kept only the contructor. The reason is I don't want to deal with data memorized in my browser and reset them every time I conduct a new search. Added Foundation Grid in index page and put thumbnails class and button success/alert class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.